Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synq MultiEvents might break WebDriver #14

Closed
alechenninger opened this issue Jul 25, 2014 · 3 comments
Closed

Synq MultiEvents might break WebDriver #14

alechenninger opened this issue Jul 25, 2014 · 3 comments
Labels
Milestone

Comments

@alechenninger
Copy link
Member

MultiEvents spin up separate threads for each event. WebDriver is not thread safe. This could be a big problem if both events are interacting with the driver.

@alechenninger
Copy link
Member Author

Access to underlying driver for multiple elements and windows needs to be restricted to a single thread:

For reference:
https://groups.google.com/forum/#!topic/webdriver/cw_awztl-IM

Simon's suggested approach would be best: since we have multiple WebElement references running around potentially being used by multiple "event" threads, having everything delegated to a single thread for a driver would solve this relatively elegantly.

The only other thing I can think of would be to completely redesign MultiEvent's in Synq... but considering I wanted them to be handle Event listening in addition to polling... I'm not sure of any other way. Plus, I quite like how it is implemented.

@alechenninger
Copy link
Member Author

Work started on making driver access thread safe, among other refactorings: c9c4b85

@alechenninger
Copy link
Member Author

Merged into master.

Needs tests though... 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant