Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality fix - The members of an interface declaration or class should appear in a pre-defined order. #68

Closed
wants to merge 1 commit into from
Closed

Code quality fix - The members of an interface declaration or class should appear in a pre-defined order. #68

wants to merge 1 commit into from

Conversation

faisal-hameed
Copy link
Contributor

This pull request is focused on resolving occurrences of Sonar rule
squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1213

Please let me know if you have any questions.

Faisal Hameed

@coveralls
Copy link

Coverage Status

Coverage remained the same at 34.167% when pulling 1fc52ab on DevFactory:release/ordering-of-member-should-be-correct-fix-1 into d074b3a on darcy-framework:master.

@alechenninger
Copy link
Member

Hi @faisal-hameed . I should publish this more widely, but for our code style we follow the Google Java style guide1 which does not have an explicit ordering requirement, only that ordering has some logical reasoning. In these examples, I have put the static factories (essentially named constructors) before the normal constructor because I believe when someone is reading these classes, the named constructors to be more useful, since these are typically how these objects will be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants