Use selenium 3.4.0 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SessionNotFoundexception was previously depricated and then removed in Selenium 3.0.0
It should technically be backwards compatibile if your automation project only references darcy apis. But if you were still referencing selenium-rc, that's going to break.
abocz
approved these changes
Aug 14, 2017
| @@ -37,6 +38,7 @@ | |||
| @Before | |||
| public void checkForDriver() { | |||
| assumeTrue(System.getProperty("java.class.path").contains("firefox-driver")); | |||
| assumeNotNull(System.getProperty("webdriver.gecko.driver")); | |||
There was a problem hiding this comment.
Worth adding a test for gecko driver?
There was a problem hiding this comment.
The FirefoxBrowserFactoryTest does run and pass if you run it in an environment with the geckodriver binary installed. I got the impression that wasn't possible in travis environment, so I treated it the same as ChromeDriver, IEDriver, etc. Happy to fix it if I misunderstood.
|
Oh no you're fine, I misunderstood the check! My bad. I'll merge next I get
to a PC.
…On Tue, Aug 22, 2017, 4:47 PM Jimmy VerVaecke ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/test/java/com/redhat/darcy/webdriver/FirefoxBrowserFactoryTest.java
<#73 (comment)>
:
> @@ -37,6 +38,7 @@
@before
public void checkForDriver() {
assumeTrue(System.getProperty("java.class.path").contains("firefox-driver"));
+ assumeNotNull(System.getProperty("webdriver.gecko.driver"));
The FirefoxBrowserFactoryTest does run and pass if you run it in an
environment with the geckodriver binary installed. I got the impression
that wasn't possible in travis environment, so I treated it the same as
ChromeDriver, IEDriver, etc. Happy to fix it if I misunderstood.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADVabz1GepeoMZn9P_jCFIbx0DjMoKxtks5saz55gaJpZM4Oz5J->
.
|
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#72
FYI, it looks a number of the BrowserDriver constructors have been deprecated in selenium 3. Probably should also deprecate those in the darcy browser factories, but let me know what you think.