Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS/Android home screen icon when using "Add to Home Screen" option in the share menu #33

Closed
wants to merge 2 commits into from
Closed

Add iOS/Android home screen icon when using "Add to Home Screen" option in the share menu #33

wants to merge 2 commits into from

Conversation

overflowy
Copy link

@overflowy overflowy commented Apr 2, 2022

I created an icon in Figma and added it to the template file to make the shortcut icon look better on the home screen. Resource files have been added to /assets.

Before:

photo_2022-04-02_23-56-13

After:

photo_2022-04-02_23-26-00

@overflowy overflowy closed this Apr 4, 2022
@overflowy
Copy link
Author

Closed because this pull request should've been made in the frontend repository.

@darekkay
Copy link
Owner

darekkay commented Apr 4, 2022

Hey @overflowy , thanks for providing this pull request! 🙂

Yes, the change has to be applied in the other repository, but I can take this up.

Some thoughts:

  • We should keep the favicon and home screen icons in sync. I'm not a designer, and the current favicon is a quick mix of two existing icons (bookmark and thunder). I like the idea of having this combination, fitting the name "static marks", but your suggested icon has an overall better feel. So I'm fine replacing the favicon with a new design as well.
  • When I look at the icon, it immediately looks like a thunder. But after a few seconds it "disintegrates". Someone told me it looks like a "yoyo" and now I cannot unsee it 😅
  • The icon looks nice and simple - but it introduces a risk of being too similar to some other - possibly copyrighted - logos. After a quick search I have found this and this and this.

What do you think? Do you see any chance to address my points, possibly by having a try at the initial thunder + bookmark combination idea?

@overflowy
Copy link
Author

Hey @darekkay

I think you're right, we should definitely keep the icons in sync. The original icon's meaning didn't initially click for me, but now that you explained it clearly I also think we should stick to it 😄

These are the new variations:

favicon
Favicon
icon
Home screen icon

As you can see, the flash looks more like a flash and less like a yoyo 😁

Regarding your last concern, I couldn't find anything that looks too similar with new the icon:

chrome_Rcgp8HhYQv

All in all, I hope you like the new design 🤞

Do you want me to make another pull request in the other repo?

@darekkay
Copy link
Owner

darekkay commented Apr 5, 2022

Awesome, thanks for all the work, the icons look great! Can you please also provide the SVGs, so we can store them for future reference (e.g. to create other sizes)?
I can take up the actual repository changes based on your work.

@overflowy
Copy link
Author

Hey @darekkay, I created a pull request here: darekkay/static-marks-app#6

@darekkay
Copy link
Owner

darekkay commented Apr 5, 2022

@all-contributors please add @overflowy to maintenance

@allcontributors
Copy link
Contributor

@darekkay

I've put up a pull request to add @overflowy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants