Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie Links to route to page (using NuxtLink) #197

Closed
2 tasks done
mouldt opened this issue Mar 17, 2024 · 3 comments · Fixed by #199
Closed
2 tasks done

Cookie Links to route to page (using NuxtLink) #197

mouldt opened this issue Mar 17, 2024 · 3 comments · Fixed by #199

Comments

@mouldt
Copy link
Contributor

mouldt commented Mar 17, 2024

Describe the feature

At present we can have links for cookies where more information can be provided. Whether you configure this with a page route e.g. /MyCookiePolicy or an external route e.g. http://mysite/cookiepolicy the link is always rendered using an tag, which means Nuxt will perform a full page load.
If would be nice if we could use Nuxt/Vue routing to close the CookieDialog and perform a Page navigation.

The fix could be something like this in the modal dialog:
<NuxtLink
v-if="!entry[0].startsWith('http')"
:to="entry[0]"
@click="isModalActive = false"
>{{ entry[1] || entry[0] }}
{{ entry[1] || entry[0] }}

i.e. if its not an external link use Nuxt/Vue routing otherwise use the tag and treat the link as external.

Additional information

  • Would you be willing to help implement this feature?

Final checks

@dargmuesli
Copy link
Owner

Sounds good to me, no potential issues come to my mind right now. PR welcome!

@dargmuesli
Copy link
Owner

🎉 This issue has been resolved in version 8.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dargmuesli
Copy link
Owner

🎉 This issue has been resolved in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants