Added option to fire change event to be compatible with default behavior #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the default change event to be fired at the appropriate times. As it stands now, the plugin breaks default behavior and makes it very difficult to integrate into applications. For example, the
ifChanged
event fires multiple times both before and after the actual change has happened with no way to differentiate between the two and theifClicked
event doesn't fire when keyboard shortcuts are used. Even if these events are to be used they require everyone in a codebase to know them and can remember to use the propriatary methods and event names. This PR makes all of this a non-issue by enabling default behavior with events and event naming.Since you didn't have a contributors file, I wasn't sure what to do about versioning as well as your prefered minifier so I ran it through Closure Compiler and left the version numbers all the same (1.0.2)
This PR would address #244
Let me know of any feedback including if you would like me to include examples, update
README
with new options, or change version numbers.