Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black screen since last update, if share mounted #85

Open
mcnahum opened this issue Oct 16, 2020 · 7 comments
Open

Black screen since last update, if share mounted #85

mcnahum opened this issue Oct 16, 2020 · 7 comments

Comments

@mcnahum
Copy link

mcnahum commented Oct 16, 2020

Hello,
I just updated the module and now I have a black screen ... only if I use my mounted share
if I use the local photos no issue, if I mount the share on my NAS where there is subfolders with subfolders and a lot of of pictures... nothing is display

On DEV mode I can see a 404 when he try a GET but I'm not sure of the issue... I will try a revert to the previous version

@SCHokie
Copy link

SCHokie commented Nov 16, 2020

I can confirm same behavior; if pointing to a folder of files which is a mounted SMB share, black-screen only. If the exact same files are copied locally, they display fine. Anyone solve this yet?

@mcnahum
Copy link
Author

mcnahum commented Nov 16, 2020

I downgraded to the previous version...

@darickc
Copy link
Owner

darickc commented Nov 16, 2020

I wonder if this is related to this pull request: #86 . Though that was merged on Oct 30th, so before the original issue.

@MystaraTheGreat
Copy link

I've also been having an issue with a share mounted set of files.
Take a look at my comment here:
#90 (comment)

It might explain the problem

@rakuri255
Copy link

Seems the problem is related to #86.
Also without the encodeUri, space in the path doesnt work!

@darickc
Copy link
Owner

darickc commented May 12, 2021

I've changed how the files are loaded. Instead of getting a list from the server and sending it to the browser and then the browser loading by making a http get; I am loading the list of images on the server and storing it there, then when a new image is to be loaded, it reads it on the server, base64 encodes the image, then passes that up to the browser using web sockets. This should fix any path or filename issues because it doesn't need to be url safe. This also means that you should be able to pass any valid path to the images, instead of it having to be under the magic mirror path. There is also now an option to resize the image on the server before it is passed to the browser. This is better for performance if using animations.

I did break one piece where you can pass a list of images from another module, but everything else should work.

If anyone would like to test and let me know if there are issues, that would be great.

@Aikagi000
Copy link

Adding to this, Mine also tanked but the images are all local in the modules folder. Restarting MM doesn't help as it presents a black screen on start with the cursor. No other modules load AND in fact the MM window gets stuck and just says "Electron" it never makes it to say "Magic Mirror". As soon as I comment out this module MM works perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants