Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing "use strict" option #31

Closed
krzysztofpniak opened this issue Sep 13, 2020 · 4 comments
Closed

missing "use strict" option #31

krzysztofpniak opened this issue Sep 13, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@krzysztofpniak
Copy link

How can I add "use strict" at the begging of the inlined web worker script?
@darionco darionco added the enhancement New feature or request label Sep 13, 2020
@darionco
Copy link
Owner

That's not possible right now, most modern platforms do not need "use strict" since it is enabled by default, but definitely something that can be useful for some scenarios.

I think adding an explicitStrict boolean option would solve this issue, I'll add it next time I work on this plugin in a couple days.

Thakns

@krzysztofpniak
Copy link
Author

Cool, I'm looking forward to it.
Anyways, I have newest chrome and it doesn't seem to have it enabled by default, at least in web worker context.

@darionco
Copy link
Owner

Because rollup uses strict mode by default, I decided to let rollup insert 'use strict'; at its own discretion, which is always.

Released in 1.4.0

@krzysztofpniak
Copy link
Author

Thanks for a quick action. Now it works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krzysztofpniak @darionco