Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the editor over to the apiserver by default #3508

Closed
9 tasks done
pbiggar opened this issue Feb 24, 2022 · 3 comments
Closed
9 tasks done

Switch the editor over to the apiserver by default #3508

pbiggar opened this issue Feb 24, 2022 · 3 comments
Assignees

Comments

@pbiggar
Copy link
Member

pbiggar commented Feb 24, 2022

Some users would like to try the v2 canvas. We would also like some users to try this.

There are two parts to this:

  • loading the /a/ route from ApiServer
  • calling the api

Switching /a/ over

To allow users to switch over, we could provide a new route that routes to F#

  • make a new route that points to the apiserver: /a-testing-fsharp/CANVASNAME
    • add to ingress
    • add to apiserver

To fully switch the /a/CANVASNAME route to the Apiserver, while still allowing /api/CANVASNAME to go to OCaml, we would need:

  • port all the functions (or at least have their metadata listed).
  • fix issues that come up ()
  • test top 50 canvases to check if they still load
  • switch /a/CANVASNAME to apiserver by default

Users don't care too much about this, it's just loading a page. So maybe the second part is more important.

Switching /api/ over

If we add a ?fsharp-backend option to the client, it could use a different api, perhaps /api-private-for-testing-only/

This allows the user to opt-in for API calls.

  • add to the client
  • add api routes to the ingress
@pbiggar
Copy link
Member Author

pbiggar commented Mar 9, 2022

@pbiggar pbiggar changed the title Allow users opt in to apiserver Switch the editor over to the apiserver by default Mar 17, 2022
@pbiggar
Copy link
Member Author

pbiggar commented Mar 17, 2022

  • There's a current issue that the ApiServer doesn't load due to blazor in some cases, so waiting for this to pass before we can declare this done.

@pbiggar
Copy link
Member Author

pbiggar commented Mar 22, 2022

Finished this in #3619.

@pbiggar pbiggar closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant