Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Runtime: Improve handling of language server failures #5308

Open
Tracked by #5252
StachuDotNet opened this issue Feb 19, 2024 · 0 comments
Open
Tracked by #5252

CLI Runtime: Improve handling of language server failures #5308

StachuDotNet opened this issue Feb 19, 2024 · 0 comments
Assignees
Labels
internal-only This involves CI, our infra, or otherwise should be done by an internal dev

Comments

@StachuDotNet
Copy link
Member

Our language server is run by our darklang CLI runtime/executable, in a long-running function that's constantly consuming stdin and putting responses on stdout.

Generally this works great -- we get JSON blobs in, and put JSON blobs out.

However, we aren't currently handling failures very gracefully -- if there's a runtime exception, we end up printing that, which isn't json and thus causes the language server (and the extension which houses it) to fail/crash.

I imagine we'll support a darklang lsp command which will have special functionality for handling such failures gracefully.

@StachuDotNet StachuDotNet self-assigned this Feb 19, 2024
@StachuDotNet StachuDotNet added the internal-only This involves CI, our infra, or otherwise should be done by an internal dev label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-only This involves CI, our infra, or otherwise should be done by an internal dev
Projects
None yet
Development

No branches or pull requests

1 participant