How to extend Suit Bootstrap? (include js after bootstrap.min.js) #149

macedd · 2013-09-13T15:24:23Z

In suit, bootstrap.min.js is included within the template after the page content.

Bootstrap plugins needs to be included after the bootstrap.min.js inclusion. I'm willing to use the Media class to include this files, as needed.

The problem is that Media files are included in the head, so they cant extend bootstrap, which is instantiated later.

Any tips on the best way to overpass this issue?

darklow · 2013-09-13T15:33:14Z

The fastest solution, but not the cleanest, i could think of is adding bootstrap.min.js to extrahead before {{ block.super }} where the {{ media.js }} is included later.

You can do this in base_site.html template file.
Unfortunately it means boostrap.min.js will be included twice, but it should work until i find and implement some proper fix.

{% block extrahead %}
  <script src="{% static 'suit/bootstrap/js/bootstrap.min.js' %}"></script>
  {{ block.super }}
{% endblock %}

macedd · 2013-09-17T00:19:31Z

I had to move the declarations from footer to head, as you mentioned, but cleaning also suit/templates/admin/base.html suit and bootstrap declarations.
On the redeclaration (footer bootstrap.min.js) the extends gone with the wind.

Is this a viable fix? (to move js to head)

django-sekizai seems to be putting the JSs in the footer. Maybe we can look at their code

darklow · 2013-09-17T04:40:38Z

The fix is easy one, but the decision either to move bootstrap.min.js to head or move {{ media.js }} to footer near other scripts is the hard one, still thinking of pros/cons for each.

darklow · 2013-09-17T19:40:48Z

I moved bootstrap.min.js to <head> before {{ media.js }}.
Please test if it works correctly using latest development version:

pip uninstall django-suit
pip install https://github.com/darklow/django-suit/tarball/develop

darklow closed this as completed in f633803 Sep 17, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

How to extend Suit Bootstrap? (include js after bootstrap.min.js) #149

How to extend Suit Bootstrap? (include js after bootstrap.min.js) #149

macedd commented Sep 13, 2013

darklow commented Sep 13, 2013

macedd commented Sep 17, 2013

darklow commented Sep 17, 2013

darklow commented Sep 17, 2013

How to extend Suit Bootstrap? (include js after bootstrap.min.js) #149

How to extend Suit Bootstrap? (include js after bootstrap.min.js) #149

Comments

macedd commented Sep 13, 2013

darklow commented Sep 13, 2013

macedd commented Sep 17, 2013

darklow commented Sep 17, 2013

darklow commented Sep 17, 2013