Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broken Website] DuckDuckGo is white-themed once again #11325

Closed
2 tasks done
ghostid234856 opened this issue May 26, 2023 · 20 comments
Closed
2 tasks done

[Broken Website] DuckDuckGo is white-themed once again #11325

ghostid234856 opened this issue May 26, 2023 · 20 comments

Comments

@ghostid234856
Copy link

ghostid234856 commented May 26, 2023

Prerequisites

  • I searched for any existing report about this website issue to avoid opening a duplicate.
  • I can reproduce this website issue in a new, unmodified web browser profile with Dark Reader installed as the only extension.

Website Issue Description

I've seen a closed issue for this back in 2018, and I've opened a new one to mention this because it seems to have been closed and may not be fully relevant. No present/recent open or closed issue reports seem to be mentioning this, surprisingly

Basically all of the DuckDuckGo site + the search engine results, images, other tabs, etc, are broken again. They are white themed permanently.

Hope yalls can help. This has been tested both on my main Firefox browser and Chrome as well.

Website Address

https://duckduckgo.com/

Steps To Reproduce

  1. Install the newest release freshly on Firefox or Chrome
  2. Open up DuckDuckGo or choose it as your main browsing engine
  3. Google something

Screenshots

Example screenshots:

image

image

Operating System

Linux -

Web Browser name and version

Linux - Parrot OS 5.3 (Electro Ara) x86_64 latest, kernel 6.1.0-1parrot1-amd64

Dark Reader version

4.9.63 release

Additional Context

No response

@dioxias
Copy link

dioxias commented May 27, 2023

same thing for me

@partingscientist
Copy link
Contributor

partingscientist commented May 28, 2023

This is due to the website using the darkreader-lock meta tag, which is why I asked for a solution to override this in #11320.

@Uj947nXmRqV2nRaWshKtHzTvckUUpD

where is this tag documented?

@puelp
Copy link

puelp commented May 30, 2023

@bershanskiy, is there no way for the user to override the 'darkreader-lock' function?

Because of 'darkreader-lock', sites essentially have the ability to lie to Dark Reader about dark-themed when they aren't.

That would be fine if the user had the ability to override 'darkreader-lock' and manually enable dark mode, but toggling the filters did nothing for me.

Am I missing something?

@Uj947nXmRqV2nRaWshKtHzTvckUUpD
Copy link

but why duckduckgo lie about this.. it doesn't make sense to me. could it be to force the user to save preferences with their dark theme in the delicious cookies, this way implementing some kind of tracking?

@alexconstant9108
Copy link

@fusionneur that'd be my guess as well. Tracking purposes. Right now, if you browse anonymously, you always get the white theme (because your dark theme preferences aren't saved between sessions)

@alexconstant9108
Copy link

alexconstant9108 commented May 30, 2023

Am I missing something?

We need an additional option to override this flag as @partingscientist has mentioned above

@javaskript
Copy link

We need an additional option to override this flag as @partingscientist has mentioned above

Agreed. I don't want any website to be able to disallow me from using DarkReader.

@rongil
Copy link

rongil commented Jun 1, 2023

I also agree it would be nice to have an override for the lock built into Dark Reader itself for cases like this one where the lock is being used despite the site not being dark-themed.

As a workaround in the meantime, if you're already using uBlock Origin, you can add duckduckgo.com##^meta[name=darkreader-lock] as a static filter to remove the attribute (same for any other site you want to override).

@alexconstant9108
Copy link

As a workaround in the meantime, if you're already using uBlock Origin, you can add duckduckgo.com##^meta[name=darkreader-lock] as a static filter to remove the attribute (same for any other site you want to override).

The meta tag does indeed get removed but Dark Reader doesn't seem to care about that fact. My guess is that it detected the meta tag being there before uBlockO removed it... Should I restart DR after loading DDG or...?

@rongil
Copy link

rongil commented Jun 1, 2023

As a workaround in the meantime, if you're already using uBlock Origin, you can add duckduckgo.com##^meta[name=darkreader-lock] as a static filter to remove the attribute (same for any other site you want to override).

The meta tag does indeed get removed but Dark Reader doesn't seem to care about that fact. My guess is that it detected the meta tag being there before uBlockO removed it... Should I restart DR after loading DDG or...?

That's odd. I did not restart anything after adding the filter. In fact, just refreshing a previously loaded light-themed DDG search page after adding the filter caused it to become dark-themed. I'm not sure what determines the execution order between the extensions. Maybe try uninstalling and reinstalling DR if you happened to have installed it before uBO originally?

@alexconstant9108
Copy link

Nah, DR got installed much later than oBO. It's a weird issue indeed.

@Uj947nXmRqV2nRaWshKtHzTvckUUpD

switched to startpage instead which in my opinion is better nowadays than duckduckgo

@yegg
Copy link

yegg commented Jun 10, 2023

This is only a temporary bandaid until #11047 -- [Performance Issue] DarkReader slowing down DuckDuckGo rendering in Chrome (recent change) -- is fixed, which is slowing down all DuckDuckGo searches and was causing a massive amount of complaints. We offer a dark theme which is a temporary solution and you can force it using URL params, e.g., https://duckduckgo.com/?q=test&kae=d&ia=web. In any case, we could use your help getting that performance bug fixed and are open to any other suggestions of better short-term fixes.

@alexconstant9108
Copy link

Is anyone now experiencing a similar issue on GitHub where if GH's dark theme is enabled, DR doesn't apply its settings?

@Uj947nXmRqV2nRaWshKtHzTvckUUpD
Copy link

Is anyone now experiencing a similar issue on GitHub where if GH's dark theme is enabled, DR doesn't apply its settings?

for me it works. which page are you trying?

@partingscientist
Copy link
Contributor

This is only a temporary bandaid until #11047 is fixed. .... We offer a dark theme which is a temporary solution and you can force it using URL params ....

Thank you for the clarification. I would still advocate for a native solution to solve #11320, considering what Gabriel suggested is not fully supported in Firefox at the moment (1195005).

@partingscientist
Copy link
Contributor

partingscientist commented Jun 28, 2023

Here's a proper workaround for Firefox users (works also for other browser, but Gabriel's method is probably preferred):

If you are using uBlock Origin:

  1. Add the following to the My Filters tab:
    duckduckgo.com##+js(trusted-set-cookie, ae, d)

If you are using AdGuard:

  1. Add the following to the User rules tab:
    duckduckgo.com#%#//scriptlet("trusted-set-cookie", "ae", "d")

@Uj947nXmRqV2nRaWshKtHzTvckUUpD

seems to be working fine now... can any1else confirm to close this?

@Micovec
Copy link

Micovec commented Mar 31, 2024

I can confirm it's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests