Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for Windows app theme instead of the system theme #11614

Open
1 task done
fasifas opened this issue Aug 18, 2023 · 2 comments
Open
1 task done

Comments

@fasifas
Copy link

fasifas commented Aug 18, 2023

Prerequisites

Is this feature request related to a problem?

No

Feature Request Description

I wish that this extension would use the Windows app theme instead of the system theme.

Currently, if I set Windows colors to "Custom" with:

  • Windows mode: Dark
  • Default App mode: Light (AppsUseLightTheme)

then darkreader is still activated. Probably because it respects the Windows mode over App mode. This is uncommon. App mode is what should actually be used, as this is what all other apps (Firefox, Word etc...) adhere to. "Windows mode" is more of a Windows OS-only thing. That is it only affects OS-related UI parts.

https://learn.microsoft.com/en-us/windows-hardware/customize/desktop/unattend/microsoft-windows-shell-setup-themes-uwpappsuselighttheme

Screenshots

No response

Additional Context

No response

@FeralFlora
Copy link

I really hope this gets implemented, because I always keep the system theme dark, but have the app theme switching to light in the mornings, and dark in the evenings.

@FeralFlora
Copy link

Probably because it respects the Windows mode over App mode

That's actually not what is occurring. What is actually happening is that Dark Reader in auto mode actually follows the browser theme in both Firefox and Edge. I guess you also have set the Firefox theme to dark? (check about:addons -> themes).

If you set the browser theme to dark, and Dark reader to auto (and "use system colour scheme"), it's always dark. Similarly, if Firefox's theme is light, Dark Reader in auto mode will always be light. It's only if Firefox's theme is set to "System theme - Auto" that Dark Reader will follow the Window's configured app theme, because that's what Firefox does. So even in this case, Dark Reader is just following the Firefox / browser theme.

See my demonstration of this here: AutoDarkMode/Windows-Auto-Night-Mode#825 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants