-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Dark Reader + RFP causes Fennec 116/Mull 116 to become unresponsive or show pages partially #11631
Comments
I just remembered even Firefox Beta has access to about:config. Flipping RFP there and using Dark Reader doesn't seem to cause this bug. Does that mean this bug is already fixed (as of 117.0b9)? |
because context was left out: https://gitlab.com/divested-mobile/mull-fenix/-/issues/82#note_1525643244 |
I can confirm identical behaviour on desktop firefox 116.0.3 (115 worked fine), so this is probably not limited to fennec/mull. |
This happens with Dark Reader in dynamic mode, but filter, filter+ and static mode seem unaffected (at least to me). Maybe the dynamic mode is looping endlessly? In this case, issue #11546 may be related. |
@lfourquaux that could definitely be the case, as my laptop fan was going crazy and |
Firefox 116 (desktop and Android) was released on August 1 (https://whattrainisitnow.com/calendar) and Dark Reader version 4.9.65 was released shortly after, on August 10: https://addons.mozilla.org/en-US/firefox/addon/darkreader/versions. To determine whether this regression was caused by a code change in Dark Reader 4.9.65 or Firefox 116, has anyone tested:
|
Happens for me was well on mull browser on android latest version 116.3. Whole page freezes and never loads. dark reader version 4.9.65. However I didn't experience this on fennec same versions combo Can confirm that fennec has privacy.resistFingerprinting set as false while mull has it true (in about: config) Disabing dark reader in mull fixes the issue |
On my phone, the problem appeared before the upgrade to 4.9.65, probably after the upgrade to Firefox (Fennec) 116. |
I tried reproducing in Windows Firefox 116 by installing Dark Reader (4.9.65), setting the I was hoping I could use the mozregression tool to bisect the Firefox Nightly builds and identify the first bad build. If anyone has reliable steps to reproduce on Firefox Desktop, here are the instructions for testing with mozregression: |
@cpeterso I tested DR 4.9.65 with Fenix Beta 115.0b9, and I don't see the bug. I can install Fenix Beta 116.0b9, but there's currently no way to install an older version of an extension on Android, as you know.
I can confirm this too. Only dynamic mode has this problem. Setting it to one of the others lets you browse normally. But they are quite inferior to dynamic mode (some websites are white with filter+, some with filter, so you have to keep switching frequently). |
Darkreader 4.9.65 Abrowser 97.0.2 - no problem |
Here's a Firefox bug reporting tracking this regression: https://bugzilla.mozilla.org/show_bug.cgi?id=1848474 |
117 also has the bug. Description updated. |
Has it been figured out where the bug fix needs to occur? In FF's code, or DR's? |
Don't know if this is related but Dark Reader was making unable for me to interact with pages on Fennec/Mull. |
Yes, that's what this bug is about. But you shouldn't have this bug on Fennec, unless you enable RFP manually. Mull has it on by default. |
RFP = resist fingerprinting? I have edit: oops, didn't realize it's on Android. Anyway, looks like almost the same thing happens on desktop since recently (only with DarkReader enabled) |
I have been using Dark Reader for some time on mull and haven't encounter the same unresponsive pages issue again |
Prerequisites
Bug Description
This template bullet is quite restrictive. RFP counts as modifying the browser profile, but it's necessary to reproduce the bug here.
Anyway, ever since version 116, Fennec/Mull have been facing this bug where page display and interactions become problematic.
It has many manifestations:
And so on.
This bug does not occur on 115 and below. It is new in 116. It also occurs on 117.
Website Address
N/A
Steps To Reproduce
Expected Behavior
Just like 115 and below, browsing should be unaffected.
Actual Behavior
The combo of the extension (as of version 4.9.65) and the pref causes pages to stop loading halfway, or not load at all, or become unresponsive, etc.
Screenshots
No response
Operating System
Android 13
Web Browser name and version
Mull/Fennec 116.3.0 and 117.0.0
Dark Reader version
4.9.65
Additional Context
No response
The text was updated successfully, but these errors were encountered: