Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Similar domains being being recognized as the same one #3729

Open
carlos-siestrup opened this issue Sep 27, 2020 · 4 comments
Open

[BUG] Similar domains being being recognized as the same one #3729

carlos-siestrup opened this issue Sep 27, 2020 · 4 comments
Labels

Comments

@carlos-siestrup
Copy link

Describe the bug

A domain is being darkned because it is similar to another domain on the list.

Steps to reproduce

Expected behavior

www.wuxiaworld.co should always get darkned by the extension but www.wuxiaworld.com should not.

Actual behavior

Both domains are being darkned by the extension

System Information:

  • OS: Windows 10
  • Browser: Chrome 85.0.4183.121
  • Dark Reader version: 4.9.21
@VFDan
Copy link
Contributor

VFDan commented Sep 28, 2020

I understand why this is happening. "www.wuxiaworld.com" includes "www.wuxiaworld.co" in the URL, and thus style is being applied.

@MicroBeast
Copy link

MicroBeast commented Sep 28, 2020

@carlos-siestrup. Because it seem you use Whitelist set up for Dark Reader, adding ^www.wuxiaworld.co$ instead will give what you ask.

Edit: ^ not necessary.

@carlos-siestrup
Copy link
Author

^www.wuxiaworld.co$ or www.wuxiaworld.co$ are not working. Adding $ is making dark reader stop darkening on both not just the one with .com.
I use the option to darken the sites listed.

@VFDan
Copy link
Contributor

VFDan commented Oct 2, 2020

I think www.wuxiaworld.co\/ should work, but this is untested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants