Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view-source has white background #4149

Closed
sthiele opened this issue Nov 16, 2020 · 6 comments
Closed

view-source has white background #4149

sthiele opened this issue Nov 16, 2020 · 6 comments
Labels

Comments

@sthiele
Copy link

sthiele commented Nov 16, 2020

Describe the bug

On Firefox, if I right click on a website and choose "View Page Source" from the context menu I get a page with white background.

view-source:https://darkreader.org/

Steps to reproduce

Expected behavior

A dark source view.

Actual behavior

A bright source view.

System Information:

  • OS: Linux
  • Browser: Firefox 82.0.3
  • Dark Reader version: 4.9.23
@sthiele sthiele added the bug label Nov 16, 2020
@Yash-Singh1
Copy link
Contributor

@sthiele
I think that the view-source protocol is protected from extensions in firefox. This can be enabled with the following on google-chrome:

  • In the new UI, go to Settings > Site List and enable on restricted pages
  • Enable the chrome://flags/#extensions-on-chrome-urls flag

firefox has prevented access to the protocol for security purposes.

@sthiele
Copy link
Author

sthiele commented Nov 17, 2020

Is this the same why the raw content is black on white with firefox?
https://raw.githubusercontent.com/darkreader/darkreader/master/README.md

@Yash-Singh1
Copy link
Contributor

Yash-Singh1 commented Nov 17, 2020

No, that isn't supposed to be happening:
Screenshot from 2020-11-16 21-07-49
Is darkreader enabled and raw.githubusercontent.com given access?

@sthiele
Copy link
Author

sthiele commented Nov 17, 2020

Is darkreader enabled and raw.githubusercontent.com given access?

Yes. I don't have this issue on chrome.

@Yash-Singh1
Copy link
Contributor

Yash-Singh1 commented Nov 17, 2020

@sthiele
Hmm...

You are not alone. I am experiencing this problem also:
Screenshot from 2020-11-17 08-18-19

It is only on that site

@Gusted
Copy link
Contributor

Gusted commented Nov 17, 2020

Hi @sthiele and @Yash-Singh1!

firefox has prevented access to the protocol for security purposes.

That's correct and for an add-on it's not possible to bypass or do anything related to make it still work

Is this the same why the raw content is black on white with firefox?
https://raw.githubusercontent.com/darkreader/darkreader/master/README.md

That's another issue #1446 and already a bug has been filled for this at bugzilla however it wasn't updated the last 4 months so I will have a comment on this, if their was any progression or any reason to have this behaviour as for ^ view-source it's for security reasons, but I don't quite understand for normal text pages.

Regards,
Gusted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants