Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user to enable local files access #475

Closed
Svish opened this issue May 8, 2018 · 18 comments
Closed

Notify user to enable local files access #475

Svish opened this issue May 8, 2018 · 18 comments

Comments

@Svish
Copy link

Svish commented May 8, 2018

When opening html and txt files directly from disk (or network share, if that matters), i.e. when the browser URL protocol is file://, then the dark mode does not work. No dark mode no matter how much I enable or disable or whitelist or blacklist. 😕

@alexanderby
Copy link
Member

Try open chrome://extensions, find Dark Reader there, click Allow access to file URLs.

@Svish
Copy link
Author

Svish commented May 9, 2018

Would you look at that... that fixed it. So I guess actual title of this issue should be: Notify about that setting somehow in the extension?

@ghost
Copy link

ghost commented May 12, 2018

It's actually described here.

@Svish
Copy link
Author

Svish commented May 14, 2018

Yeah, but there could be a notification the first time one opens a local file for example.

@alexanderby alexanderby changed the title Doesn't work for local files Notify user to enable local files access Nov 2, 2018
@Evpok
Copy link

Evpok commented Sep 27, 2019

Also this does not seem to work in firefox ?

@chibby0ne
Copy link

I've looked for a similar setting in Firefox and haven't found it. Is anyone aware if this is possible in a recent version of Firefox (eg: version > 80)?

@Gusted
Copy link
Contributor

Gusted commented Aug 22, 2020

Also this does not seem to work in firefox ?

Right

I've looked for a similar setting in Firefox and haven't found it. Is anyone aware if this is possible in a recent version of Firefox (eg: version > 80)?

Not that I'm aware of.

@marcospb19
Copy link

Wait that's a option???????

Omg I've been searching for this for a long time.

What about this FAQ? When I click on the extension icon, there's no FAQ listed there, is the user supposed to search the website to find it?

IMHO this is not the best way to advertise this important feature.

@Gusted
Copy link
Contributor

Gusted commented Sep 19, 2020

What about this FAQ? When I click on the extension icon, there's no FAQ listed there, is the user supposed to search the website to find it?

Their is a "help" button in the UI. As we don't only provide a little FAQ but also some other explaination of other features as well, so the wording "help" was the best option.

IMHO this is not the best way to advertise this important feature.

Uhm, the browser(only chrome) allows this after fuzzing around the settings of the extension. It's not that we blocks this feature intentionally.

@marcospb19
Copy link

The Dev Tools button is bigger than the help one.

Is it really as important as the GitHub link? The link to the FAQ?

I'm trying to be critic in a constructive way because I love this software, I've been using it for a LONG TIME, and I just wish the best for it, that said, I think that the UI should be more clear about this to the users that aren't being very attentive.

This "enable for local files" is generally more useful for the general user than Dev Tools.

@Gusted
Copy link
Contributor

Gusted commented Sep 19, 2020

The Dev Tools button is bigger than the help one.

Is it really as important as the GitHub link? The link to the FAQ?

I'm trying to be critic in a constructive way because I love this software, I've been using it for a LONG TIME, and I just wish the best for it, that said, I think that the UI should be more clear about this to the users that aren't being very attentive.

This "enable for local files" is generally more useful for the general user than Dev Tools.

Well, what's your opinion on the new UI?

Devtools -> Preview new Design.

The help button is now under the settings button and bigger. All other related links are gone now(only the donate one for obvious reasons).

@marcospb19
Copy link

marcospb19 commented Sep 19, 2020

Well, what's your opinion on the new UI?

GREAT!, I'm sorry for opining about an outdated interface, I was basing my thoughts in what I have here now.

@Gusted
Copy link
Contributor

Gusted commented Sep 19, 2020

GREAT!, I'm sorry for opining about an outdated interface, I was basing my thoughts in what I have here now.

No problems, it's still a preview and not the default one. But we are already tackling your issue with the new UI.

@Gusted
Copy link
Contributor

Gusted commented Aug 25, 2021

#6566 has been merged to take care of this issue.

@Gusted Gusted closed this as completed Aug 25, 2021
@sksmsWKd
Copy link

Try open chrome://extensions, find Dark Reader there, click Allow access to file URLs.

Thanks you save my eyes

@scarlion1
Copy link

I've looked for a similar setting in Firefox and haven't found it. Is anyone aware if this is possible in a recent version of Firefox (eg: version > 80)?

In Firefox it seems that setting security.fileuri.strict_origin_policy=false (about:config) will allow Dark Reader to work on file:// URI's. Dark Reader still says it's disabled for the current website but it's definitely enabled and applying the theme. The toggle to enable/disable for the current website (file:// URI) doesn't work, and I can't change it from "Theme for all websites" to a custom theme for the current site, but the settings for the theme for all websites will be applied, at least. Maybe firefox needs to be restarted for the add-on to fully work, but I'm in the middle of some other things and can't do a restart right now.

You can read about the implications of this setting here.

@avenarius-argus
Copy link

avenarius-argus commented May 8, 2023

I've looked for a similar setting in Firefox and haven't found it. Is anyone aware if this is possible in a recent version of Firefox (eg: version > 80)?

In Firefox it seems that setting security.fileuri.strict_origin_policy=false (about:config) will allow Dark Reader to work on file:// URI's. Dark Reader still says it's disabled for the current website but it's definitely enabled and applying the theme. The toggle to enable/disable for the current website (file:// URI) doesn't work, and I can't change it from "Theme for all websites" to a custom theme for the current site, but the settings for the theme for all websites will be applied, at least. Maybe firefox needs to be restarted for the add-on to fully work, but I'm in the middle of some other things and can't do a restart right now.

You can read about the implications of this setting here.

I tried this method and firefox crashed and restarted again, the dark feature for local files are turned on then off, then added the file to the list of the extension, the magic happened!

@scarlion1
Copy link

scarlion1 commented Dec 1, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants