Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No overwrite an object on deserialization in Message #20

Closed
rawlik opened this issue May 17, 2021 · 1 comment
Closed

No overwrite an object on deserialization in Message #20

rawlik opened this issue May 17, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@rawlik
Copy link

rawlik commented May 17, 2021

Quick Description

The documentation mentions a function to overwrite an object on deserialization without a reference.

Explanation

The documentation points to the DarkRift.message.Deserialize<T>() : https://www.darkriftnetworking.com/DarkRift2/Docs/2.9.1/advanced/serialization.html
and claims

It is also possible to pass DarkRift an object to overwrite on deserialization to reduce garbage generation.

This functionality is only provided by DarkRiftReader.ReadSerializableInto<T>().

The documentation should best state, that more functionality is provided by DarkRiftReader.

@JamJar00
Copy link
Member

This method will be added into the next version of DarkRift, good spot about the mismatch!

@JamJar00 JamJar00 added the bug Something isn't working label Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants