Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed. Semaphore is removed from storage too early. Find better solution #7

Open
darksidecat opened this issue May 11, 2021 · 2 comments
Open

Fixed. Semaphore is removed from storage too early. Find better solution #7

darksidecat opened this issue May 11, 2021 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@darksidecat
Copy link
Owner

There are cases when a semaphore is removed from storage too early

I add tests for these cases, but need investigation for finding solution to prevent this
@darksidecat darksidecat added bug Something isn't working help wanted Extra attention is needed labels May 11, 2021
@darksidecat
Copy link
Owner Author

darksidecat commented May 11, 2021 •
edited
Loading

These tests for this bug:

aiopriman/tests/manager/test_semaphore_manager.py

Line 97 in 0237748

async def test_sem_no_cant_find_key_warning_odd(caplog):

@darksidecat
Copy link
Owner Author

maybe there is better way to fix this

@darksidecat darksidecat reopened this May 11, 2021
@darksidecat darksidecat changed the title Semaphore is removed from storage too early Fixed. Semaphore is removed from storage too early. Find better solution May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@darksidecat