Skip to content
This repository has been archived by the owner on Dec 28, 2022. It is now read-only.

importing settings fails when prefs.json is too long #237

Closed
schaedi opened this issue Dec 16, 2016 · 2 comments
Closed

importing settings fails when prefs.json is too long #237

schaedi opened this issue Dec 16, 2016 · 2 comments

Comments

@schaedi
Copy link

schaedi commented Dec 16, 2016

I found that importing settings did not work for me. I set up my newtab page with 7x8 tiles and a lot of settings. These settings can not be re-imported after being exported from newtabtools.
I debugged export.jsm and found, that the line 246 "utf8Stream.readString(8192, data);" in function readZippedJSON gave me only part of my settings-file, what I assume is the buffer-size (that number 8192) is less than my settings-lenght. Parsing this data fails, no import-dialog is shown.

@darktrojan
Copy link
Owner

Okay, I see the problem. It looks like I forgot to keep reading once the buffer is full. I'm surprised your file is big enough to have a problem, but here we are.

I've got a fix which I'll put in the next version. Thank you for writing a helpful report!

@darktrojan
Copy link
Owner

I've just pushed this to the add-ons site for review. I meant to do so a lot earlier, but forgot! Sorry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants