Feature 32 build tests in tpl mode #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifflander
reviewed
Mar 6, 2019
| @@ -27,8 +27,7 @@ file( | |||
| # | |||
| macro(checkpoint_link_target target has_mpi) | |||
| target_include_directories(${target} PUBLIC ${PROJECT_TEST_UNIT_DIR}) | |||
| target_link_libraries(${target} PRIVATE GTest::GTest) | |||
There was a problem hiding this comment.
Is it ok that we are loosing the namespace here? Or am I missing something?
There was a problem hiding this comment.
When building using find_package(GTest), GTest::GTest and GTest::Main are defined and both included in the variable GTEST_BOTH_LIBRARIES as a result of the find_package call. When in TPL mode, we don't use find_package, so none of that is true. Instead, I am setting GTEST_BOTH_LIBRARIES to the actual library names because that is all I can do (without stealing code from the FindGTest cmake module).
There was a problem hiding this comment.
Ah, I see. That makes sense now
lifflander
approved these changes
Mar 10, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some tweaks so that checkpoint can find gtest when building in TPL mode. I also deleted the (unused) configure option I added before we decided to change the behavior of find_package_local.