Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on multisite install #56

Closed
grahammtbr opened this issue Feb 9, 2021 · 5 comments
Closed

Doesn't work on multisite install #56

grahammtbr opened this issue Feb 9, 2021 · 5 comments

Comments

@grahammtbr
Copy link

Like the title says. No errors or anything, just didn't work.

Not a big deal for me, I just rolled that client back to ver. 1.3, it's fine on that version with WP's infinite backwards compatibility 馃槃

@darrenjacoby
Copy link
Owner

darrenjacoby commented Feb 18, 2021

Hey @grahammtbr ,

So this is an interesting one. I'm assuming you're using a 'super' administrator user, viewing multisite dashboards. WordPress doesn't seem to pass any user roles for the super administrator role, or administrator role on a network level, so we're left with an empty $current_user->roles array, and therefore Intervention doesn't apply the config file. Using wp-admin.all actually did still work as it bypasses checking for user roles.

I pushed a fix to add the administrator user role manually if the array is empty and multisite is activated, 2285826. Give it a go and let me know if it solves the above issue for you!

@grahammtbr
Copy link
Author

Thanks Darren. I could have sworn I tried wp-admin-all and it didn't work, but I tried it again (with the some version) and it worked... I must have been asleep at the wheel.

Thanks for all your work on this, it's definitely appreciated. It's the config file I always wanted to create, but never got around to!

@darrenjacoby
Copy link
Owner

@grahammtbr hah, it happens! So, to confirm, the latest fix (on dev-master) is working as well with wp-admin.administrator? I want to make sure you get the role capabilities on multisite too. It's a pleasure, and thank you for the nice words!

@darrenjacoby
Copy link
Owner

darrenjacoby commented Feb 24, 2021

Hey @grahammtbr , just checking if it's all working on your end and I can close the issue?

@grahammtbr
Copy link
Author

Sorry, missed this. Yes, it's working. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants