Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alarm for when temperature drops below certain threshold #4

Closed
Eloston opened this issue Nov 24, 2017 · 11 comments
Closed

Alarm for when temperature drops below certain threshold #4

Eloston opened this issue Nov 24, 2017 · 11 comments
Assignees

Comments

@Eloston
Copy link

Eloston commented Nov 24, 2017

Some users use their devices in cold environments, where the battery could get too cold for it to operate well (and cause the device to suddenly power off). If you could add a lower temperature threshold alarm type, that would be great!

@darshan- darshan- self-assigned this Nov 24, 2017
@darshan-
Copy link
Owner

Thanks for the suggestion! That's not something I would have ever thought of, as it's not something I've ever run into, but it makes sense. I've added it to my to-do list. I'm quite busy with other things at the moment, so I'm not sure when I'll get to it. But it's an easy thing to add, so it should make it into the next update, whenever I do that.

@darshan-
Copy link
Owner

Okay, I just added this to the app. The update should be out in the next few days for devices running Android 8.0 and up. I don't think I'll support this feature old older versions of Android unless you, as the filer of the issue, let me know that you're still using older Android, in which cases I'll make that happen. (For the overall Android ecosystem, 8.0+ is relatively small still, but for this app it's pushing 50% of my users.)

@Eloston
Copy link
Author

Eloston commented Sep 12, 2018

Awesome! Unfortunately, I've since switched to a new device, a new environment, and upgraded to Android 8.1. If I ever run into a similar situation, I'll know what to use ;)

Thanks for following through on the issue!

@ildar
Copy link

ildar commented Nov 8, 2018 via email

@darshan-
Copy link
Owner

darshan- commented Nov 8, 2018

Due to major changes in Android's notification system, it's significantly easier for me to maintain the app with minSdkVersion 26 for new features at this point. Backporting this feature to the build for older devices is feasible but not something I have time for right now while I'm extremely busy with other things. I'll seriously consider adding it when I have a bit of spare time. Thanks.

@robinpaulson
Copy link

It'd be interesting to set minsdk to 23, but include the new features which require API 26. It could then gracefully fall back if the new feature is not available, while still partially supporting older SDK versions. Is this possible at all in Android?

Repository owner deleted a comment from Josephdecotis Nov 11, 2018
@darshan-
Copy link
Owner

Yeah, that's how it works in general. The difference here is that Google has a new policy requiring apps to target 26 now, which has significant changes to how notifications work. It was much, much less work for me to handle this by having two builds now. One for 16+ and one for 26+. Both are maintained and supported with security and bug fixes, but feature development happens for the 26+ version. It's quite feasible to backport small features like this to the 16+ version when I have some spare time.

@robinpaulson
Copy link

Great, thanks for the info darshan and keep up the good work. Robin

@ildar
Copy link

ildar commented Nov 13, 2018 via email

@darshan-
Copy link
Owner

Version 10.0.4 is the API level 16+ track, which is where we're talking about backporting this feature at some point. If you're running Android 8.0 or higher, please use version 11.0.2, which is where this feature currently exists. Thanks.

@ildar
Copy link

ildar commented Nov 13, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants