Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use HDF5 macro H5_VERSION_GE rather than our own autoconf logic #754

Closed
shanedsnyder opened this issue Jun 14, 2022 · 1 comment
Closed

Comments

@shanedsnyder
Copy link
Contributor

We currently have autoconf logic that determines whether HDF5 version is 1.10+ or not. That happens to be sufficient for our current instrumentation code, but HDF5 library does have a lot of API changes across versions we may need to protect against (e.g., see 981c315).

HDF5 has macros (H5_VERSION_GE, H5_VERSION_LE, etc.) we can use that give us complete access to major/minor/bugfix release numbers rather than writing them ourselves, we should just switch to those to simplify.

@shanedsnyder
Copy link
Contributor Author

I actually decided to just use AC_CHECK_FUNCS autoconf logic to detect presence of specific HDF5 functions we wrap/use, rather than trying to capture what versions these functions are available in. For example, see 2e6a73d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant