You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently have autoconf logic that determines whether HDF5 version is 1.10+ or not. That happens to be sufficient for our current instrumentation code, but HDF5 library does have a lot of API changes across versions we may need to protect against (e.g., see 981c315).
HDF5 has macros (H5_VERSION_GE, H5_VERSION_LE, etc.) we can use that give us complete access to major/minor/bugfix release numbers rather than writing them ourselves, we should just switch to those to simplify.
The text was updated successfully, but these errors were encountered:
I actually decided to just use AC_CHECK_FUNCS autoconf logic to detect presence of specific HDF5 functions we wrap/use, rather than trying to capture what versions these functions are available in. For example, see 2e6a73d
We currently have autoconf logic that determines whether HDF5 version is 1.10+ or not. That happens to be sufficient for our current instrumentation code, but HDF5 library does have a lot of API changes across versions we may need to protect against (e.g., see 981c315).
HDF5 has macros (
H5_VERSION_GE
,H5_VERSION_LE
, etc.) we can use that give us complete access to major/minor/bugfix release numbers rather than writing them ourselves, we should just switch to those to simplify.The text was updated successfully, but these errors were encountered: