deprecate then remove *Changed listeners #120
Comments
<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly Removed Type-Defect label. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch also - if for some reason we want to keep the feature (compat with polymer.js), then we could be more careful about fooChanged and only doing something special if there is a correspoing observable property named foo. I also lean towards removing the feature. |
<img src="https://avatars.githubusercontent.com/u/5606182?v=3" align="left" width="48" height="48"hspace="10"> Comment by ussuri As a user of the feature, I can attest that it's always seemed "too magical" to me. It's seemed to be in a stark contrast with the explicitness of, say, @CustomTag('my-element') class MyElement. So yes, making it more explicit would be more user-friendly and less error-prone. |
<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly Removed Area-Polymer label. |
<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly Removed Library-Polymer label. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch Added this to the 1.6 milestone. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch Removed this from the 1.6 milestone. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch Removed Polymer-P-1 label. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch Added PolymerMilestone-Next label. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch Removed Polymer-Milestone-Next label. |
<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly @jakemac53 is this fixed in new polymer? |
<img src="https://avatars.githubusercontent.com/u/984921?v=3" align="left" width="48" height="48"hspace="10"> Comment by jakemac53 Yes in the new polymer these methods will no longer exist |
<img src="https://avatars.githubusercontent.com/u/984921?v=3" align="left" width="48" height="48"hspace="10"> Comment by jakemac53 Closing this because I will forget later |
<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="96" height="96"hspace="10"> Issue by jmesserly
Originally opened as dart-lang/sdk#16993
"Changed" is a magic method suffix:
http://www.polymer-project.org/docs/polymer/polymer.html#change-watchers
it's happened quite a few times that people get errors because of this feature... they expect to use *Changed as an event listener and not have it be magic.
I think we should remove this feature from the Dart port, as it is largely replaced by another feature that is more explicit and IMHO more obvious (@ObserveProperty -- currently in our under development 0.10.0-dev pkg, inspired by this polymer.js feature: http://www.polymer-project.org/docs/polymer/polymer.html#observeblock), and fits the polymer.dart pattern of using metadata for things recognized by the base class.
The text was updated successfully, but these errors were encountered: