You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 19, 2017. It is now read-only.
We have situations where we report errors in a line that is transformed, so users can't see where the error really comes from. For example:
> [Warning bwu_fontawesome_iconset_svg|example/index.html]: line 1537, column 1: private symbols cannot be used in event handlers
This error is detected in script compactor after all the inlining is done, so we end up reporting an error in line 1537 for a file with just 66 lines.
Probably the easiest solution is to move some of the checks for private symbols into the linter, which is processing files before any transformation happens.
To avoid parsing all the template expressions twice, we could pass the extracted data as an asset to the later phase.
The text was updated successfully, but these errors were encountered:
This is closer to be working, we still do inlining before we do some portions of the linting. However, Jake did a large refactoring that will make it easier to compose one transformer after another. We should be able to pass the HTML document from one transformer to the next, instead of reparsing the HTML. That way the original source-spans will be preserved, and error messages will contain the correct location.
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="96" height="96"hspace="10"> Issue by sigmundch
Originally opened as dart-lang/sdk#20126
We have situations where we report errors in a line that is transformed, so users can't see where the error really comes from. For example:
> [Warning bwu_fontawesome_iconset_svg|example/index.html]: line 1537, column 1: private symbols cannot be used in event handlers
This error is detected in script compactor after all the inlining is done, so we end up reporting an error in line 1537 for a file with just 66 lines.
Probably the easiest solution is to move some of the checks for private symbols into the linter, which is processing files before any transformation happens.
To avoid parsing all the template expressions twice, we could pass the extracted data as an asset to the later phase.
The text was updated successfully, but these errors were encountered: