Skip to content
This repository has been archived by the owner on Dec 19, 2017. It is now read-only.

support arbitrary expressions in url attributes #423

Closed
DartBot opened this issue Jun 5, 2015 · 5 comments
Closed

support arbitrary expressions in url attributes #423

DartBot opened this issue Jun 5, 2015 · 5 comments

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="96" height="96"hspace="10"> Issue by sigmundch
Originally opened as dart-lang/sdk#20286


works: <img src="foo/{{bar}}">
fails: <img src="foo/{{bar[3]}}">

(just adding a test in import_inliner_test.dart will replicate the issue)

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


Jake - since you recently fixed the other issue, I thought maybe you might like to take a look at this one.


Set owner to @jakemac53.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


Marked this as blocking #228.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/984921?v=3" align="left" width="48" height="48"hspace="10"> Comment by jakemac53


Added Started label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/984921?v=3" align="left" width="48" height="48"hspace="10"> Comment by jakemac53


Fix pending in https://codereview.chromium.org/433913002.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/984921?v=3" align="left" width="48" height="48"hspace="10"> Comment by jakemac53


Fixed in dart-lang/sdk@4a9130b


Added Fixed label.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants