Skip to content
This repository has been archived by the owner on Dec 19, 2017. It is now read-only.

Collapse together errors of the same kind #459

Closed
DartBot opened this issue Jun 5, 2015 · 2 comments
Closed

Collapse together errors of the same kind #459

DartBot opened this issue Jun 5, 2015 · 2 comments

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="96" height="96"hspace="10"> Issue by sigmundch
Originally opened as dart-lang/sdk#20424


It's common to see one warning/error repeated in many places. For example the href vs _href might happen a lot now that we introduce the warning for it. It would be great to combine all occurrences of the same error together.

Some ideas:

  • for the log_injector UI, we can combine it graphically.
  • for the pub-build/pub-serve output in stdout, we can delay reporting warnings until the end of the phase, collect all warnings together and report them as such. At least we can do that on a file-per-file basis.
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


It would also be great to sort errors by severity - all warnings are right now treated equal, but we probably want to rank them in some order.

This order might not be entirely static. For example, consider these 3 errors:
 a- there is an error of a broken import
 b- an warning in a template
 c- an warning that an element definition was not found.

I'd rank them in that order, because it's common that (c) is a consequence of (a). But if 'a' error is not there, I'd sort (c) before (b).

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


Comment #­1 seems big enough to deserve a separate bug. I moved it to issue dart-lang/sdk#6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants