Skip to content
This repository has been archived by the owner on Aug 1, 2019. It is now read-only.

Add support for getSourceReport - now final #6

Closed
kevmoo opened this issue Apr 11, 2016 · 4 comments
Closed

Add support for getSourceReport - now final #6

kevmoo opened this issue Apr 11, 2016 · 4 comments
Assignees
@kevmoo
Labels
enhancement

Comments

@kevmoo
Copy link
Contributor

kevmoo commented Apr 11, 2016

The VM Service has now added a stable getSourceReport API – it was added at some point in 1.16 SDK

Would be good to expose this API in this package.
@kevmoo kevmoo mentioned this issue Apr 11, 2016
Closed
@nex3
Copy link
Contributor

nex3 commented Apr 14, 2016 •
edited

@johnmccutchan @turnidge: What version of the VM service protocol first included this method? Did it come with any additional methods? There isn't any documentation of this either in the SDK changelog or in the service protocol revision history.

@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 20, 2016

Looks like it was added in 3.1 - see here dart-lang/sdk@bf385e4

@kevmoo kevmoo mentioned this issue Apr 27, 2016
Closed
@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 28, 2016

https://codereview.chromium.org/1929063002/

@kevmoo kevmoo self-assigned this Apr 28, 2016
@pulyaevskiy
Copy link

Wondering if this can be prioritized? This may seem like a low priority but a lot of community package builds are broken because of this and coverage package.

@kevmoo kevmoo closed this as completed in 167eb9c May 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kevmoo kevmoo

Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nex3 @kevmoo @pulyaevskiy