Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Homepage download links don't work #110

Closed
alanjoyce opened this issue Nov 5, 2013 · 4 comments
Closed

Homepage download links don't work #110

alanjoyce opened this issue Nov 5, 2013 · 4 comments
Labels

Comments

@alanjoyce
Copy link
Contributor

Both the general download button in the header and the OS-specific ones at the bottom of the page don't work yet.

@adam-singer
Copy link
Contributor

The download button fixed at the bottom at adam-singer@c757f53

What should the header download button point to at default. I guess the logic should be the same for the buttons at the bottom but the class needs one different attribute.

@adam-singer
Copy link
Contributor

btw, this will contain merge conflicts when rebasing with the main dartlang site. Not bad todo, I got most of a rebase done today but had to abort it cause something might of broken in the main tree in terms of getting the version files.

@alanjoyce
Copy link
Contributor Author

Bottom links look good.

For the header download button, let's follow the same logic as the buttons, so ideally it will default to the user's OS and change if the user changes it at the bottom.

@ghost ghost assigned adam-singer Nov 7, 2013
@adam-singer
Copy link
Contributor

fixed at: adam-singer@d5a7199

screen shot 2013-11-08 at 10 03 47 am
screen shot 2013-11-08 at 10 03 26 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants