This repository has been archived by the owner on Jul 16, 2023. It is now read-only.
feat: introduce prefer-provide-intl-description rule #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
incendial
reviewed
Jan 6, 2023
...r/rules/rules_list/prefer_provide_intl_description/prefer_provide_intl_description_rule.dart
Outdated
Show resolved
Hide resolved
dkrutskikh
force-pushed
the
prefer-provide-intl-description
branch
from
628fc92
to
5e969bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1137 +/- ##
==========================================
+ Coverage 85.48% 85.53% +0.04%
==========================================
Files 347 349 +2
Lines 7841 7868 +27
==========================================
+ Hits 6703 6730 +27
Misses 1138 1138
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
incendial
reviewed
Jan 7, 2023
website/docs/rules/index.mdx
Outdated
| severity="warning" | ||
| version="5.5.0" | ||
| > | ||
| Warns when a `Intl` method invocation without description. |
There was a problem hiding this comment.
Warns when a method is invoked without a description.
incendial
reviewed
Jan 7, 2023
|
|
||
| <RuleDetails version="5.5.0" severity="warning" /> | ||
|
|
||
| Warns when a `Intl.message()`, `Intl.plural()`, `Intl.gender()` or `Intl.select()` method invocate without description. |
There was a problem hiding this comment.
Warns when the .... methods are invoked without a description.
incendial
approved these changes
Jan 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?