Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

feat: exclude .freezed.dart files by default #1139

Merged
merged 2 commits into from Jan 8, 2023
Merged

Conversation

dkrutskikh
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #1139 (400052f) into master (d0613f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1139   +/-   ##
=======================================
  Coverage   85.48%   85.48%           
=======================================
  Files         347      347           
  Lines        7839     7841    +2     
=======================================
+ Hits         6701     6703    +2     
  Misses       1138     1138           
Impacted Files Coverage Δ
lib/src/cli/commands/base_command.dart 73.91% <ø> (ø)
lib/src/analyzers/lint_analyzer/lint_analyzer.dart 92.54% <100.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -8,7 +8,7 @@ const _usage = 'Check unused localization in *.dart files.\n'
'-h, --help Print this usage information.\n'
'\n'
'\n'
'-p, --class-pattern=<I18n\$> The pattern to detect classes providing localization\n'
'-p, --class-pattern=<I18n\$> The pattern to detect classes providing localization\n'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary empty space?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. \$ takes one character

@incendial incendial merged commit 592cd3d into master Jan 8, 2023
@incendial incendial deleted the exclude-freezed branch January 8, 2023 11:11
@incendial incendial added this to the 5.5.0 milestone Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants