Remove --enable-new-task-model flag.

BUG= R=paulberry@google.com Review URL: https://codereview.chromium.org//1389113002 .
googlearchive · Oct 6, 2015 · 7dcdbb3 · 7dcdbb3
1 parent 3e199e4
commit 7dcdbb3
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 36 deletions.
diff --git a/lib/src/driver.dart b/lib/src/driver.dart
@@ -91,8 +91,6 @@ class Driver {
     // Parse commandline options.
     CommandLineOptions options = CommandLineOptions.parse(args);
 
-    AnalysisEngine.instance.useTaskModel = options.enableNewTaskModel;
-
     // Cache options of interest to inform analysis.
     _setupEnv(options);
 

diff --git a/lib/src/options.dart b/lib/src/options.dart
@@ -44,9 +44,6 @@ class CommandLineOptions {
   /// Whether to display version information
   final bool displayVersion;
 
-  /// Whether to enable the new task model.
-  final bool enableNewTaskModel;
-
   /// Whether to enable null-aware operators (DEP 9).
   final bool enableNullAwareOperators;
 
@@ -111,7 +108,6 @@ class CommandLineOptions {
         analysisOptionsFile = args['options'],
         disableHints = args['no-hints'],
         displayVersion = args['version'],
-        enableNewTaskModel = args['enable-new-task-model'],
         enableNullAwareOperators = args['enable-null-aware-operators'],
         enableStrictCallChecks = args['enable-strict-call-checks'],
         enableSuperMixins = args['supermixin'],

diff --git a/test/driver_test.dart b/test/driver_test.dart
@@ -8,7 +8,6 @@ library analyzer_cli.test.driver;
 import 'dart:io';
 
 import 'package:analyzer/plugin/options.dart';
-import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/plugin/plugin_configuration.dart';
 import 'package:analyzer_cli/src/bootloader.dart';
 import 'package:analyzer_cli/src/driver.dart';
@@ -36,28 +35,6 @@ main() {
       });
     });
 
-    group('experimental flags', () {
-      bool savedTaskModelStatus;
-      setUp(() {
-        savedTaskModelStatus = AnalysisEngine.instance.useTaskModel;
-      });
-
-      tearDown(() {
-        AnalysisEngine.instance.useTaskModel = savedTaskModelStatus;
-      });
-
-      test('enable tasks', () {
-        expect(AnalysisEngine.instance.useTaskModel, savedTaskModelStatus);
-        Driver driver = new Driver();
-        try {
-          driver.start(['--enable-new-task-model', 'test/data/test_file.dart']);
-        } catch (e) {
-          //TODO(pq): https://github.com/dart-lang/analyzer_cli/issues/65
-        }
-        expect(AnalysisEngine.instance.useTaskModel, true);
-      });
-    });
-
     group('exit codes', () {
       int savedExitCode;
       ExitHandler savedExitHandler;

diff --git a/test/options_test.dart b/test/options_test.dart
@@ -20,7 +20,6 @@ main() {
         expect(options.disableHints, isFalse);
         expect(options.lints, isFalse);
         expect(options.displayVersion, isFalse);
-        expect(options.enableNewTaskModel, isFalse);
         expect(options.enableStrictCallChecks, isFalse);
         expect(options.enableSuperMixins, isFalse);
         expect(options.enableTypeChecks, isFalse);
@@ -50,12 +49,6 @@ main() {
         expect(options.definedVariables['bar'], isNull);
       });
 
-      test('enable new task model', () {
-        CommandLineOptions options = CommandLineOptions
-            .parse(['--dart-sdk', '.', '--enable-new-task-model', 'foo.dart']);
-        expect(options.enableNewTaskModel, isTrue);
-      });
-
       test('enable strict call checks', () {
         CommandLineOptions options = CommandLineOptions.parse(
             ['--dart-sdk', '.', '--enable-strict-call-checks', 'foo.dart']);