Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subclasses of of Exception should be named *Exception #1

Open
kevmoo opened this issue Jun 18, 2014 · 1 comment
Open

Subclasses of of Exception should be named *Exception #1

kevmoo opened this issue Jun 18, 2014 · 1 comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@kevmoo
Copy link
Member

kevmoo commented Jun 18, 2014

Short list (there may be more)

lib/api/errors.dart:class AppEngineError implements Exception {
lib/api/errors.dart:class NetworkError extends AppEngineError implements IOException {
lib/api/errors.dart:class ProtocolError extends AppEngineError implements IOException {
lib/src/protobuf_api/rpc/rpc_service.dart:class RpcApplicationError implements Exception {
@kevmoo kevmoo changed the title Things that implement Exception should be named *Exception Subclasses of of Exception should be named *Exception Jun 18, 2014
@antoniojrod antoniojrod mentioned this issue Nov 11, 2014
Closed
@sigurdm
Copy link

sigurdm commented Sep 30, 2021

Maybe we can create type-aliases so this would be non-breaking

@sigurdm sigurdm added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevmoo @sigurdm