Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc links don't work #168

Closed
kwalrath opened this issue Apr 22, 2021 · 7 comments
Closed

Doc links don't work #168

kwalrath opened this issue Apr 22, 2021 · 7 comments

Comments

@kwalrath
Copy link

In the package page (https://pub.dev/packages/async), the API doc homepage (https://pub.dev/documentation/async/latest/), and the repo homepage (https://github.com/dart-lang/async#readme), links to the generated API doc don't work.

They go to URLs like this:
https://pub.dev/documentation/async/latest/async/AsyncCache-class.html

But the published doc's URLs are like this:
https://pub.dev/documentation/async/latest/pkg.async/AsyncCache-class.html

Which makes me wonder: did you really mean to change the library name from async to pkg.async? If so, editing the README is all that's necessary to fix this. If not...

@jonasfj
Copy link
Member

jonasfj commented Apr 23, 2021

This has already been fixed in #158, I think we just need to publish.

@jonasfj jonasfj closed this as completed Apr 23, 2021
@jonasfj jonasfj reopened this Apr 23, 2021
@jonasfj
Copy link
Member

jonasfj commented Apr 23, 2021

@natebosch, I think 376c0fe has rolling into the SDK and google3, are we good to publish it now?

@natebosch
Copy link
Member

@jonasfj - I think it is worth exploring the idea proposed in #161 (comment) first

@jayoung-lee
Copy link

@jonasfj Is this a major change? Then I think I can remove the part in the dart-lang/site-www#3147 that refers to the async package and update it later.

@jonasfj
Copy link
Member

jonasfj commented Apr 27, 2021

@natebosch, I think there are many reasons we shouldn't pursue ChunkedStreamReader as an extension on StreamQueue, can we publish this?

@natebosch
Copy link
Member

natebosch commented Apr 27, 2021

Yeah I think we can keep the reader as is. We have a few other PRs to get rolled in I will roll what we have landed in the repo so far and then I'll publish. I'll save the next batch of PRs for the next release.

@kwalrath
Copy link
Author

Looks like the links are working now. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants