Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Consider adding a buildStep.markNonHermetic() api for targeting builders that can't easily be written with good behavior #1512

Closed
natebosch opened this issue Jun 4, 2018 · 2 comments

Comments

@natebosch
Copy link
Member

If we end up with some build behavior which is annoying or impossible to base only on buildStep.readAs* inputs it might be nice to have some API to indicate that a particular builder is non hermetic and therefore must always be run on every build.

We would either make this a setting in the builder definition (and always run the builder), or give an API to mark a build step as non-hermetic dynamically so builder authors may be able to do some hermetic work and make a decision if further non-hermetic work is necessary.

@jakemac53
Copy link
Contributor

Just throwing out random ideas here, but what if we exposed an api where the builder was allowed to return some sort of state object, which was required to be serializable and comparable, and we would use that to determine if we need to re-run the builder or not.

We would have to call this api on every build for sure, but I think in most scenarios this could be just once per builder, not per builder+input combo?

@natebosch
Copy link
Member Author

Closing in favor of #967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants