Move SDK summary generation to a separate library #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The details of finding or generating the SDK summary are different internally, so this code gets patched. The patch file ends up needing frequent maintenance to keep up with unrelated other changes in this file. Separate the SDK summary related code into it's own library which will have a patch so that it is more isolated from other changes. Move `isFlutter` to `sdk_summary.dart` since it is used there, and it is related to the SDK. Update the test which imports from `src`. Move `packagePath` to `build_asset_uri_generator` so it can be used in both `resolver.dart` and `sdk_summary.dart`.
jakemac53
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details of finding or generating the SDK summary are different
internally, so this code gets patched. The patch file ends up needing
frequent maintenance to keep up with unrelated other changes in this
file. Separate the SDK summary related code into it's own library which
will have a patch so that it is more isolated from other changes.
Move
isFluttertosdk_summary.dartsince it is used there, and it isrelated to the SDK. Update the test which imports from
src.Move
packagePathtobuild_asset_uri_generatorso it can be used inboth
resolver.dartandsdk_summary.dart.