Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intent to release: 3.0.0 #180

Closed
matanlurey opened this issue Dec 13, 2017 · 11 comments
Closed

Intent to release: 3.0.0 #180

matanlurey opened this issue Dec 13, 2017 · 11 comments
Assignees

Comments

@matanlurey
Copy link
Contributor

Before we have lots more usage, we might want to try and ship 3.0.0.

Specifically, with the following breaking changes:

  • Remove automatic dartfmt with use of equalsDart.
  • Remove all uses of Annotation.
  • Change {Method|Constructor}.lambda to default to null (infer).
  • Remove all uses of File.

Any other ideas/thoughts? /cc @kevmoo @natebosch @alorenzen @thosakwe

@kevmoo
Copy link
Member

kevmoo commented Dec 13, 2017

Make sure you support latest dependencies?

@natebosch
Copy link
Member

I've been trying to figure out whether we can add support for if and else and without digging too deeply I was worried they could only be done cleanly with breaking changes. It might be nice to experiment a bit more.

@matanlurey
Copy link
Contributor Author

Sure. No rush.

I'd like to maybe get a 3.0.0-alpha with BCs for google3 validation soon (TM), and we can decide on whether we want to include other changes before shipping 3.0-final. But no rush (and not this week).

@matanlurey
Copy link
Contributor Author

@natebosch
Copy link
Member

natebosch commented Dec 27, 2017

Will migrating to 3.0.0 from angular fix any of the version solve madness? If so I'm in favor of doing that ASAP and not waiting for any more changes.

@matanlurey
Copy link
Contributor Author

matanlurey commented Dec 27, 2017

@natebosch It definitely will help, but I also don't mind depending on an alpha since Angular itself will be alpha until Dart 2.0 ships. Let me know - I can land 3.0.0-alpha internally tomorrow.

@natebosch
Copy link
Member

Anything that can improve where we are would be appreciated. I've been trying to upgrade angular to the latest build_runner and running in to lots of pain (pub upgrade works but pub get fails 😢 )

@matanlurey
Copy link
Contributor Author

3.0.0-alpha has landed in google3.

@natebosch @alorenzen @kevmoo any final feedback before 3.0.0-final?

@kevmoo
Copy link
Member

kevmoo commented Jan 8, 2018

I haven't played much with it. All for getting bits out there, though...

@kevmoo
Copy link
Member

kevmoo commented Jan 8, 2018

One blocker: #184

@matanlurey
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants