New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CanonicalizedMap
: new copy
, toMap
and toMapOfCanonicalKeys
methods
#261
Conversation
…thods. - `copy`: copies a `CanonicalizedMap` instance without recalculating the canonical values of the keys. - `toMap`: creates a `Map<K,V>` (with the original key values). - `toMapOfCanonicalKeys`: creates a `Map<C,V>` (with the canocalized keys).
I'm always a little worried when adding methods to an implementation of a standard interface like It's also reasonable functions. So thanks for the contribution! Can you update the changelog and the pubspec version as per https://github.com/dart-lang/.github/blob/main/PULL_REQUEST_TEMPLATE.md ? It should just be a minor version increment, and a changelog entry for that version saying which methods are added. |
Currently the most common use case is: It's all about performance. If you use any It is also important to have methods for transforming it into a regular Best regards |
Done 👍 |
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
copy
: copies aCanonicalizedMap
instance without recalculating the canonical values of the keys.toMap
: creates aMap<K,V>
(with the original key values).toMapOfCanonicalKeys
: creates aMap<C,V>
(with the canocalized keys).