Some refactoring #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest we change the README in a separate PR to keep the changes more isolated. Here's a small PR for that: #10 |
mit-mit
reviewed
Apr 29, 2021
| @@ -0,0 +1,10 @@ | |||
| # _docker-library | |||
|
|
|||
| This directory is a placeholder with samples for the following repos: | |||
There was a problem hiding this comment.
I'm a bit confused, I thought we talked about not having samples here?
There was a problem hiding this comment.
These are not examples for how to use our repo. These are placeholder samples of what we need to submit to the other repos as part of the process of publishing our official image.
kevmoo
approved these changes
Apr 30, 2021
|
I don't have all of the context, but this generally seems like we're moving the ball forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a bit of refactoring/restructuring to make the things we still need to do a bit clearer and to iterate somewhat on the README content. The content under
_docker-libraryis ultimately intended to be removed from this repo and become pull requests to two other repos:We could work directly with clones of those, but it might be easier to have all the content in this repo while we iterate on it.
Also note that I followed the pattern used by the official image for Node.js (which has
docker-library/docs/node/README.mepoint tonodejs/docker-node/README.mdfor how to use the image, rather than the other way around like the Go team does; since we're following the Node model a bit more by maintaining our own official repo on dart-lang outside of the docker-library org, this probably makes more sense for us.