This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Polymer 1 5 #20
Merged
Polymer 1 5 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,9 +6,10 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
I'd change this and remove the DOCTYPE, html, head, and body tags so it simply looks like:
<link rel="import" href="packages/polymer/polymer.html">
<polymer-element name="tute-slambook-form" extends="form">
...There was a problem hiding this comment.
(but yes, what you currently have is correct. Just a bit more verbose :))
|
lgtm - just a minor suggestion |
|
A few suggestions about comments, nothing of them deal breaking or earth shaking. |
|
It was hard to tell, but did you delete the |
|
|
||
| <html> | ||
| <body> | ||
| <link rel="import" href="../packages/polymer/polymer.html"> |
There was a problem hiding this comment.
minor nit - now that <html><body> are gone in all these files, you might want to unindent everything.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the polymer dart examples to 0.15.1 and incorporating Siggi's comments. Also updating the comment style to use "///" instead of "/*" for doc comments.
@kwalrath @sigmundch