Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contributors documentation to projects, and consider switching to GitHub reviews from Gerrit #127

Open
whesse opened this issue Feb 21, 2022 · 1 comment
Labels
type-enhancement A request for a change that isn't a bug

Comments

@whesse
Copy link
Contributor

whesse commented Feb 21, 2022

To encourage contributions from other authors, either instructions for how to create Gerrit CLs for changes should be added,
or the repository could be switched to use GitHub reviews.

As @devoncarew suggested when suggesting changes with a PR:
"If PR won't work here, I can recreate this work as a gerrit CL. However, it would be nice to either take PRs, or, add some brief contributing instructions to the repo to describe how to author changes.

You might consider flipping the system of record for the codebase, as that would allow us to do things like use github actions to validate the code."

@whesse whesse added the type-enhancement A request for a change that isn't a bug label Feb 21, 2022
@devoncarew
Copy link
Member

consider switching to GitHub reviews from Gerrit

One things that would be possible - if this repo moves closer to using github as the system of record - is to auto-deploy the app to firebase when changes land on master. We've set that up on one other Flutter web + firebase app in the dart-lang/ org; I can provide pointers if that's interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants