Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird formatting of list literal with inline style #138

Closed
kevmoo opened this issue Jan 14, 2015 · 2 comments
Closed

Weird formatting of list literal with inline style #138

kevmoo opened this issue Jan 14, 2015 · 2 comments
Labels

Comments

@kevmoo
Copy link
Member

kevmoo commented Jan 14, 2015

https://codereview.chromium.org/849023002/diff/1/test/args_test.dart#newcode306

const _VALID_OPTIONS = const [
  'a' // One character.
  'contains-dash',
  'contains_underscore',
  'ends-with-dash-',
  'contains--doubledash--',
  '1starts-with-number',
  'contains-a-1number',
  'ends-with-a-number8'
];

becomes

const _VALID_OPTIONS = const [
  'a' // One character.
      'contains-dash',
  'contains_underscore',
  'ends-with-dash-',
  'contains--doubledash--',
  '1starts-with-number',
  'contains-a-1number',
  'ends-with-a-number8'
];
@kevmoo kevmoo added the bug label Jan 14, 2015
@munificent
Copy link
Member

The formatter just found a bug in your code. You forgot a comma after 'a', so it's showing you that the next line is part of an adjacent string expression.

This is why automated formatting is awesome.

@kevmoo
Copy link
Member Author

kevmoo commented Jan 14, 2015

Great catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants