Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool setupCommand should run once per tool #1864

Open
jcollins-g opened this issue Dec 7, 2018 · 1 comment
Open

tool setupCommand should run once per tool #1864

jcollins-g opened this issue Dec 7, 2018 · 1 comment
Labels
P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-performance Issues related to slow dartdoc generation.

Comments

@jcollins-g
Copy link
Contributor

@gspencergoog

New ToolDefinitions are created for each ModelElement, so if defined, runSetup will actually execute once for each ModelElement it is referenced in.

Not currently a P1 because the tool definitions for Flutter don't require setups.
@jcollins-g jcollins-g added P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Dec 7, 2018
@jcollins-g
Copy link
Contributor Author

jcollins-g commented Dec 13, 2018 •
edited

Impact of this was reduced significantly as a side effect of #1865. Now it only runs a few times (technically, it runs as many times as the number of subdirectories of where the tool was defined where it is referenced).

@jcollins-g jcollins-g changed the title tool setupCommand runs once per ModelElement, not once per tool tool setupCommand should run once per tool Dec 13, 2018
@srawlins srawlins added the type-performance Issues related to slow dartdoc generation. label Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-performance Issues related to slow dartdoc generation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srawlins @jcollins-g