Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter changelog version extraction #103

Closed
M123-dev opened this issue May 22, 2023 · 1 comment · Fixed by #104
Closed

Smarter changelog version extraction #103

M123-dev opened this issue May 22, 2023 · 1 comment · Fixed by #104
Labels
package:firehose type-enhancement A request for a change that isn't a bug

Comments

@M123-dev
Copy link
Contributor

Hey there, firstly, thanks for publishing an in-house workflow to automate the release. We are planning to move over from a handwritten one, though for versioning we are using release please (https://github.com/google-github-actions/release-please-action) to create the changelog.

The headers are not only the version but also the date and a link to the commit history

## [2.5.1](https://github.com/openfoodfacts/openfoodfacts-dart/compare/v2.5.0...v2.5.1) (2023-05-21)

which results in the error

(error) pubspec version (2.5.1) and changelog (2.5.1 (2023-05-21)) don't agree  

Instead of using the whole header name, the version should be extracted

@devoncarew devoncarew added the type-enhancement A request for a change that isn't a bug label May 22, 2023
@devoncarew
Copy link
Member

Thanks for the issue! Note that this package isn't necessarily intended to be widely used; we're publishing it for our own benefit. I'll update the readme to clarify that.

That said, I don't think we're opposed to making the changelog version parsing logic more robust. The main thing we care about is that the pubspec version == the changelog version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants