Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double comments on PR #143

Closed
mosuem opened this issue Jul 20, 2023 · 0 comments · Fixed by #144
Closed

Double comments on PR #143

mosuem opened this issue Jul 20, 2023 · 0 comments · Fixed by #144
Labels
package:firehose type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@mosuem
Copy link
Member

mosuem commented Jul 20, 2023

In some cases, the REST call to get the current comment ID fails with a Connection closed before full header was received message, see https://github.com/dart-lang/i18n/actions/runs/5608361709/jobs/10260625131.

This then leads to a second comment being created, instead of the existing one being reused.
@mosuem mosuem added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) package:firehose labels Jul 20, 2023
@mosuem mosuem mentioned this issue Jul 20, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:firehose type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix comment posting from forks dart-lang/ecosystem
1 participant
@mosuem