This repository has been archived by the owner on May 24, 2023. It is now read-only.
Add a secondarySort parameter to topologicalSort
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to enforce a topological sort but ensure that within that, existing nodes are sorted lexically as much as possible.
|
I might not have time for a closer review until Monday. What is the use case? |
|
My specific use-case is wanting to sort a list of BUILD targets topologically, but also cluster them by directory as much as possible to avoid redundant |
natebosch
reviewed
Feb 7, 2022
natebosch
approved these changes
Feb 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to enforce a topological sort but ensure that
within that, existing nodes are sorted lexically as much as possible.