Skip to content
This repository has been archived by the owner on Jan 20, 2018. It is now read-only.

use ConstantEvaluator for primitive values #22

Closed
sigmundch opened this issue Feb 12, 2015 · 1 comment
Closed

use ConstantEvaluator for primitive values #22

sigmundch opened this issue Feb 12, 2015 · 1 comment

Comments

@sigmundch
Copy link
Contributor

When inlining the const constructor of an initializer annotation, we could use ConstantEvaluator to determine if the value is a simple primitive, if so, just write the primitive value (since they are cannonicalized).

This will allow us to support @HtmlImport in more cases, since we need to extract the string argument from it.

@jakemac53
Copy link
Contributor

In the new plugin architecture which is coming, this won't be an issue. Plugins will have access to the fully resolved AST and can do this on their own as needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants