This repository has been archived by the owner on Apr 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2635450534
💛 - Coveralls |
Closing this PR in favor of new branch. |
This was referenced Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds JNI to FFI plugin, along with android support
There are several generated files which can be hard to review.
To verify reproducibility
run tool/gen_aux_methods.dart in jni/ folder
run
dart run ffigen --config ffigen.yaml
to generate bindings to jni.h ; The header file is copied from Android NDK plus some annotations for param names in function pointer fields. Theffigen
currently links to my fork of ffigen with a jni-specific patch, on which changes from upstreamffigen
should be easy to verify. I think that's better than committing all vendored files in the same commit.Marking it as draft to get the CI right, eventually.