New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FieldRename.pascal #475
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed the Google CLA. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I suppose the Travis build fails because |
You need to add a dependency override to |
@@ -31,7 +31,7 @@ String pascalCase(String input) { | |||
if (input.isEmpty) { | |||
return ''; | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ABDF – "always be dartfmt"ing 😄
return ''; | ||
} | ||
|
||
return input[0].toUpperCase() + input.substring(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lrhn is input[0]
better/worse than input.substring(0, 1)
?
@natebosch @jakemac53 – thoughts on this? |
Going to wait on Lasse to comment on the string bits...
*From: *Nate Bosch <notifications@github.com>
*Date: *Wed, May 8, 2019 at 2:58 PM
*To: *dart-lang/json_serializable
*Cc: *Kevin Moore, Comment
*@natebosch* approved this pull request.
…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#475 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAEFCQWVZJ5IHICMREOFXDPUNEGXANCNFSM4HLLHRFQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some pubspec/changelog tweaks that should be done, but I'll take care of those.
Thanks!
Adds a
pascal
value to theFieldRename
enum, for PascalCase JSON field name encoding.Resolves #474.